Skip to content

[action-translation] resync: imp_sample.md#116

Merged
mmcky merged 3 commits into
mainfrom
resync/imp_sample
Jul 19, 2026
Merged

[action-translation] resync: imp_sample.md#116
mmcky merged 3 commits into
mainfrom
resync/imp_sample

Conversation

@mmcky

@mmcky mmcky commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Forward Resync: imp_sample.md

Source: QuantEcon/lecture-python.mystlectures/imp_sample.md
Source commit: b8ed85c
This PR resyncs the translation to match the current source document.

Reason: Target adds font configuration code (FONTPATH, mpl.font_manager, plt.rcParams) not in source, and adds @jit(parallel=True) decorator to the simulate function in target that is absent in source. These are code additions beyond simple i18n font config in one case (the @jit decorator change affects code logic), though the font config itself is typical i18n. Overall content is otherwise faithfully translated.

Changes

Whole-file resync applied. The entire document was resynced in a single pass.


Created by action-translation forward resync

Copilot AI review requested due to automatic review settings July 18, 2026 07:39
@mmcky mmcky added action-translation-sync Auto-created by action-translation resync Forward resync labels Jul 18, 2026
@netlify

netlify Bot commented Jul 18, 2026

Copy link
Copy Markdown

Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 0ebf120
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/6a5c4cc2274cf0000728c15c
😎 Deploy Preview https://deploy-preview-116--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR forward-resyncs the Chinese translation of imp_sample.md against the upstream source commit b8ed85c, bringing the translated lecture back in line with the source content and updating translation sync metadata.

Changes:

  • Added translation: frontmatter metadata (title + heading mapping) to lectures/imp_sample.md.
  • Removed the @jit(parallel=True) decorator and prange usage from the simulate loop to match the upstream source behavior.
  • Added translation state tracking for this file under .translate/state/.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lectures/imp_sample.md Resynced lecture translation; adds translation frontmatter and aligns the simulate implementation with the upstream source.
.translate/state/imp_sample.md.yml Records source SHA, sync date, model, and resync mode for translation tracking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mmcky mmcky added the action-translation PRs created by QuantEcon/action-translation label Jul 18, 2026
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request July 18, 2026 10:30 Inactive
The resync kept the CJK font-configuration block but dropped the mpl
import it depends on - a NameError at execution that non-strict builds
swallow. Found sweeping the wave for the pattern behind zh-cn#97's
December fixes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions
github-actions Bot temporarily deployed to pull request July 18, 2026 10:47 Inactive
@github-actions

Copy link
Copy Markdown

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-07-19


📝 Translation Quality

Criterion Score
Accuracy 9/10
Fluency 9/10
Terminology 9/10
Formatting 9/10
Overall 9/10

Summary: 整体翻译质量优秀,准确传达了原文关于似然比过程均值和重要性抽样的技术内容,术语使用规范一致,数学公式和代码结构完整保留。主要问题集中在文档后半部分(选择抽样分布章节)出现的英文半角标点符号,与前文中文全角标点不一致,建议统一修正。 数学公式和LaTeX符号完整保留,未出现渲染问题 专业术语翻译准确,如'重要性抽样'、'似然比'、'累积似然比'等均符合术语表标准 代码块结构和缩进完整保留,仅代码注释被恰当翻译 长句拆分处理得当,保持了学术文本的严谨性和可读性

Suggestions:

  • 标点符号一致性: 在'选择抽样分布'章节末尾部分(如'如果存在最优的重要性分布?'及后续段落)使用了英文半角逗号和问号(如'因此,假设'、'是否存在最优的重要性分布?'),而文档其他部分使用中文全角标点(,。?)。建议统一使用全角中文标点以保持整篇文档的一致性。
  • 代码注释翻译增补: 代码块中新增了额外的字体设置代码(FONTPATH, mpl.font_manager等),这些是源文档中没有的内容,虽然这是翻译系统的标准操作(用于中文字体渲染),但建议在评估中确认这不影响代码块与原文的对应关系。
  • 标题字段翻译: 'Choosing a sampling distribution'在heading映射中被翻译为'选择抽样分布',与之前的'Selecting a sampling distribution'翻译重复,虽然英文原文两个标题也是同义表达(selecting/choosing),但可考虑用'挑选抽样分布'等来区分两个不同章节标题,便于读者区分。

🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 10/10

Summary: The target correctly adds translation metadata mapping all headings, fixes a code bug (missing matplotlib import) and removes an erroneous jit/prange decoration on simulate that had crept into the target, aligning it with the source structure and content.


This review was generated automatically by action-translation review mode.

@github-actions
github-actions Bot temporarily deployed to pull request July 19, 2026 04:37 Inactive
@mmcky
mmcky merged commit 10ffa8c into main Jul 19, 2026
7 checks passed
@mmcky
mmcky deleted the resync/imp_sample branch July 19, 2026 04:38
mmcky added a commit that referenced this pull request Jul 20, 2026
…#183)

Resolves the four failures reported in #182. All four are target-side
defects; the English source is healthy in every case.

likelihood_bayes — the font block called `mpl.font_manager.fontManager`
and `plt.rcParams` before `import matplotlib.pyplot as plt`. Newer
matplotlib no longer imports `font_manager` as a side effect of
`import matplotlib`, so this raised AttributeError (and would have
raised NameError on `plt`). Moved the pyplot import above both uses.
An audit of the font block across all 69 lectures found this the only
file with either ordering hazard.

kalman_2 — a `.text()` annotation drew the covariance matrix with
`\begin{bmatrix}`, which matplotlib mathtext cannot render (it supports
no LaTeX environments). Rewritten as `\left[ \substack{...} \right]`,
which renders an equivalent bracketed 2x2 matrix under mathtext, using
`\;` as the column separator rather than `&`. This keeps the
drop-usetex standard from #22 intact with no loss of information.
The lecture's other `\begin{bmatrix}` uses are inside `{math}` blocks,
rendered by MathJax, and are unaffected.

sir_model — the header directive had lost its argument: `{raw}` instead
of `{raw} jupyter`. The other 50 lectures carrying this directive kept
theirs.

ak_aiyagari — the file carried a stray fence at line 38 followed by a
duplicated copy of the original frontmatter, and a doubled closing
fence at EOF. The stray opener ran to line 56, swallowing both the H1
title and the `_admonition/gpu.md` include, which is what produced the
13 "headings start at H2" warnings. Removed both strays; the file's
fence structure now matches the English source exactly (122). The
`translation.title` field was also corrupt ("V, σ, μ") and has been set
to the lecture title. An edition-wide sweep found no other file with
unbalanced fences.

The last two are content corruption introduced in translation and
warrant engine issues against action-translation; they are not covered
by the existing #107/#115/#116/#117 set.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mmcky added a commit that referenced this pull request Jul 20, 2026
* FIX: execution and doc failures from the Anaconda 2026.07 cache build

Resolves the four failures reported in #182. All four are target-side
defects; the English source is healthy in every case.

likelihood_bayes — the font block called `mpl.font_manager.fontManager`
and `plt.rcParams` before `import matplotlib.pyplot as plt`. Newer
matplotlib no longer imports `font_manager` as a side effect of
`import matplotlib`, so this raised AttributeError (and would have
raised NameError on `plt`). Moved the pyplot import above both uses.
An audit of the font block across all 69 lectures found this the only
file with either ordering hazard.

kalman_2 — a `.text()` annotation drew the covariance matrix with
`\begin{bmatrix}`, which matplotlib mathtext cannot render (it supports
no LaTeX environments). Rewritten as `\left[ \substack{...} \right]`,
which renders an equivalent bracketed 2x2 matrix under mathtext, using
`\;` as the column separator rather than `&`. This keeps the
drop-usetex standard from #22 intact with no loss of information.
The lecture's other `\begin{bmatrix}` uses are inside `{math}` blocks,
rendered by MathJax, and are unaffected.

sir_model — the header directive had lost its argument: `{raw}` instead
of `{raw} jupyter`. The other 50 lectures carrying this directive kept
theirs.

ak_aiyagari — the file carried a stray fence at line 38 followed by a
duplicated copy of the original frontmatter, and a doubled closing
fence at EOF. The stray opener ran to line 56, swallowing both the H1
title and the `_admonition/gpu.md` include, which is what produced the
13 "headings start at H2" warnings. Removed both strays; the file's
fence structure now matches the English source exactly (122). The
`translation.title` field was also corrupt ("V, σ, μ") and has been set
to the lecture title. An edition-wide sweep found no other file with
unbalanced fences.

The last two are content corruption introduced in translation and
warrant engine issues against action-translation; they are not covered
by the existing #107/#115/#116/#117 set.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* CI: align build safety with the English source repo

Resolves #184. Brings ci.yml's execution safety in line with
lecture-python.myst, which is the standard the fleet builds to.

- `-n -W --keep-going` on the sphinx-tojupyter build. Previously this
  step ran with no flags, so a notebook whose cells raised still exited
  zero and the job went green. That is how the two execution breaks in
  #182 (likelihood_bayes, kalman_2) reached main with passing CI.
- Upload Execution Reports (Download Notebooks), so a failure in that
  step leaves a traceback artifact. Previously there was none, which is
  why #182 had to be diagnosed from the weekly Build Cache workflow's
  artifact rather than from CI directly.
- Clear stale Sphinx environment (`rm -rf _build/.doctrees`) before the
  builds, matching the source repo. The equivalent was present here only
  as a commented-out note.

The HTML artifact is renamed `execution-reports` -> `execution-reports-html`.
This is required, not cosmetic: upload-artifact@v7 runs with
`overwrite: false`, so adding a second upload under the same name would
collide when both steps fail in one run. The new names match the source
repo's convention (-notebooks / -latex / -html).

The PDF/LaTeX build is left commented out — see the issue for why that
one needs a human decision rather than mechanical alignment.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* CI: set -eo pipefail on the sphinx-tojupyter step

Addresses Copilot review feedback on #185.

`shell: bash -l {0}` is a custom shell spec, so GitHub does not inject
`-eo pipefail` — it only does that for the bare `shell: bash` shorthand,
which expands to `bash --noprofile --norc -eo pipefail {0}`. Without it,
this step's exit code is that of the trailing `cp`, so a failing
`jb build` was masked.

`--keep-going` made that worse rather than better: it forces Sphinx to
emit output despite the errors, so the .ipynb files exist, `cp` succeeds,
and the step goes green. The flag added in this PR to surface failures
was producing the artifacts that hid them.

Scope is exactly one step — an audit of ci.yml shows every other step is
either single-command (its exit code is the command's) or uses the
default shell, which does carry `-e`.

Note the English source repo lecture-python.myst has the byte-identical
pattern, so this is inherited from the standard rather than introduced
here, and it deviates from the strict parity this PR set out to
establish. Reported upstream so the standard can catch up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation action-translation-sync Auto-created by action-translation resync Forward resync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants